search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

fix alias bug + refactor #510

Closed shahzzzam closed 5 years ago

shahzzzam commented 5 years ago

Purpose of the PR

Re-ordered steps for exec.

Instead of:

  1. Preprocess task
  2. Unmarshal task
  3. Expand command aliases
  4. Marshal task
  5. Render gotemplates
  6. Unmarshal Task for run

we simplify to this:

  1. Preprocess task
  2. Render gotemplates
  3. Unmarshal task for run
  4. Expand command aliases

Also as a part of #501

Fixes #511

northtyphoon commented 5 years ago

If you put Expand command aliases at the last step and the alias value references a go template, how does the go template get rendered?

shahzzzam commented 5 years ago

abandoning now

shahzzzam commented 5 years ago

do not delete the branch