search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

Refactor some code #516

Closed shahzzzam closed 4 years ago

shahzzzam commented 5 years ago

Purpose of the PR

1) Refactor templating and builder modules.

templating -> builder builder -> executor

Decouple cmd and graph. All cmd should go thru builder to build their Tasks

2) Move Alias Preprocessing logic from graph to builder

3) Move secretmgmt and tokenutil to pkg.

4) Separate out azurekeyvault from vault (renamed from vaults)

Part of #501 & #420

TODO: for 420, see if credential mgmt can be moved from executor.

northtyphoon commented 5 years ago

}

Consider rename it to Executor. Otherwise it conflicts with the new builder module.

Refers to: executor/builder.go:33 in 9811e2c. [](commit_id = 9811e2c564746aabeed928c40fd0d4277676231f, deletion_comment = False)

shahzzzam commented 5 years ago

}

Consider rename it to Executor. Otherwise it conflicts with the new builder module.

Refers to: executor/builder.go:33 in 9811e2c. [](commit_id = 9811e2c, deletion_comment = False)

yep, i was going to do that next