Improve Secrets Error Messages

Azure / acr-builder

Azure Container Registry Build Runner

MIT License

38 stars 35 forks source link

Improve Secrets Error Messages #563

Closed akashsinghal closed 4 years ago

akashsinghal commented 4 years ago

Purpose of the PR

Improve and remove wrapped error message when resolving secrets in tasks file

Fixes #557 #548

akashsinghal commented 4 years ago

@shahzzzam For #557 I have simply added to the error message to indicate to the user to check that their isn't an issue with their permissions. For #548 I removed 2 layers of wrapped errors you had indicated are not helpful. I'm not sure whether you want to remove all layers of wrapped error especially when the secret is resolving using an MSI. In my opinion, it might be helpful to keep the MSI wrapped errors especially for tracking an error that occurs on our side...