search

Azure / acr-builder

Azure Container Registry Build Runner
MIT License
38 stars 35 forks source link

ACR Tasks timeout won't go above an hour #678

Closed akagno-ent closed 5 months ago

akagno-ent commented 5 months ago

Describe the bug Timeout set for steps above one hour, but task still times out at an hour.

To Reproduce

version: v1.1.0
alias:
  values:
    Image: 'place'
    Tag: 'holder'
steps:
  - build: -t {{.Run.Registry}}/$Image:$Tag -f dockerfile .
    timeout: 4200
  - push: ["{{.Run.Registry}}/$Image:$Tag"]
    timeout: 600

Ran using this: az acr task run -n build-win -r myregistry -c docker/ado-agent/windows --set 'Tag=test' --set 'Image=ado-windows-agents'

The build takes a long time because we're building a Windows agent and installing Visual Studio on it.

Expected behavior ACR Tasks let me run an entire task (build and push) that is around an hour and 15 minutes long.

Additional context We use ADO self-hosted agents to run these commands, but don't use our own docker image builders. ACR Tasks is our attempt to avoid having to manage it ourselves.

akagno-ent commented 5 months ago

It appears as though setting the --timeout manually upon az acr task create will override the timeout for the task.