Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!
https://github.com/Azure/aks-engine
MIT License
1.03k stars 560 forks source link

Add DockerEngine feature flag #4262

Closed CecileRobertMichon closed 5 years ago

CecileRobertMichon commented 5 years ago

What this PR does / why we need it: Deployments w/ GPU nodes in sovereign clouds need to install docker-engine without VHD as Moby is not compatible w/ GPU and AKS VHD is not yet available in sovereign clouds.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4261

Special notes for your reviewer:

If applicable:

Release note:

codecov[bot] commented 5 years ago

Codecov Report

Merging #4262 into master will increase coverage by 0.02%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
+ Coverage   50.75%   50.77%   +0.02%     
==========================================
  Files         109      109              
  Lines       17053    17062       +9     
==========================================
+ Hits         8655     8664       +9     
- Misses       7614     7616       +2     
+ Partials      784      782       -2
jackfrancis commented 5 years ago

/lgtm

jackfrancis commented 5 years ago

/lgtm