search

Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!
https://github.com/Azure/aks-engine
MIT License
1.03k stars 560 forks source link

Fix issue caused by updating azure.json #4279

Closed ritazh closed 5 years ago

ritazh commented 5 years ago

What this PR does / why we need it: Fix issue caused by updating azure.json Details for the fix: https://github.com/Azure/kubernetes-kms/pull/37

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes https://github.com/Azure/aks-engine/issues/49

Special notes for your reviewer:

If applicable:

Release note:

tariq1890 commented 5 years ago

Thanks for the fix @ritazh. You will also need to update the default bool flag iirc

codecov[bot] commented 5 years ago

Codecov Report

Merging #4279 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4279   +/-   ##
======================================
  Coverage    50.5%   50.5%           
======================================
  Files         109     109           
  Lines       17160   17160           
======================================
  Hits         8666    8666           
  Misses       7710    7710           
  Partials      784     784
tariq1890 commented 5 years ago

/lgtm

feiskyer commented 5 years ago

👍