search

Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!
https://github.com/Azure/aks-engine
MIT License
1.03k stars 560 forks source link

disable heaspter for kubernetes versions > 1.12 and remove sed statements for heapster config #4316

Closed tariq1890 closed 5 years ago

tariq1890 commented 5 years ago

This PR does two things

  1. Disable Heapster for k8s clusters with version 1.12.0 or greater. As per this document , https://github.com/kubernetes/heapster/blob/master/docs/deprecation.md

  2. Remove sed statements to apply heapster configurations and use the new addon pre-render flow instead.

codecov[bot] commented 5 years ago

Codecov Report

Merging #4316 into master will decrease coverage by 4.89%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #4316     +/-   ##
=========================================
- Coverage   55.45%   50.55%   -4.9%     
=========================================
  Files         109      109             
  Lines       16053    17174   +1121     
=========================================
- Hits         8902     8683    -219     
- Misses       6368     7709   +1341     
+ Partials      783      782      -1
CecileRobertMichon commented 5 years ago

Should we close in favor of https://github.com/Azure/aks-engine/pull/109 ?

tariq1890 commented 5 years ago

yes. Closing.