Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!

https://github.com/Azure/aks-engine

MIT License

1.03k stars 560 forks source link

Add copyright headers to source files #4324

Closed mboersma closed 5 years ago

mboersma commented 5 years ago

What this PR does / why we need it:

Adds copyright headers to Go source files and enforces a make validate-headers target in CI.

Better late than never. All credit goes to @CecileRobertMichon. See also Azure/aks-engine#23.

Release note:

Add copyright headers to source files

mboersma commented 5 years ago

CircleCI was happy with the header check:

tariq1890 commented 5 years ago

can we rename validate-headers to validate-license-headers ? I think headers is too generic and not necessarily suggestive of what it's actually doing.

tariq1890 commented 5 years ago

lgtm otherwise :)

codecov[bot] commented 5 years ago

Codecov Report

Merging #4324 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4324   +/-   ##
=======================================
  Coverage   55.45%   55.45%           
=======================================
  Files         109      109           
  Lines       16054    16054           
=======================================
  Hits         8903     8903           
  Misses       6368     6368           
  Partials      783      783

codecov[bot] commented 5 years ago

Codecov Report

Merging #4324 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4324   +/-   ##
=======================================
  Coverage   55.45%   55.45%           
=======================================
  Files         109      109           
  Lines       16054    16054           
=======================================
  Hits         8903     8903           
  Misses       6368     6368           
  Partials      783      783

tariq1890 commented 5 years ago

/lgtm