search

Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!
https://github.com/Azure/aks-engine
MIT License
1.03k stars 560 forks source link

apiVersionLinkDefault still shows in some examples #4326

Closed davidmatson closed 5 years ago

davidmatson commented 5 years ago

Is this a request for help?: No

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE

What version of acs-engine?: 0.26.0

Anything else we need to know:

In #3909, apiVersionLinkDefault was removed. (I had an extension that used it and wasn't sure what to use as the replacement; I eventually figured it out by searching code history for this parameter.)

While I was searching, I found a few files that still use this now-removed parameter: https://github.com/Azure/acs-engine/search?q=apiversionlinkdefault&unscoped_q=apiversionlinkdefault

Probably worth minor cleanup here.

CecileRobertMichon commented 5 years ago

these are all DCOS template extensions and are self-sufficient (the apiVersionLinkDefault var is defined in the extension template) and were left on purpose to avoid touching DCOS code paths.