Azure / acs-engine

WE HAVE MOVED: Please join us at Azure/aks-engine!
https://github.com/Azure/aks-engine
MIT License
1.03k stars 560 forks source link

Fix default value for kublet's non-masquerade-cidr #4356

Closed mwieczorek closed 5 years ago

mwieczorek commented 5 years ago

What this PR does / why we need it: It fixes default value for non-masquerade-cidr for kubelet. According to https://github.com/kubernetes-incubator/ip-masq-agent#configuring-the-agent CIDR 0.0.0.0/0 should be used, not 0.0.0.0

I described issues it creates in #4353

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4353

Special notes for your reviewer:

If applicable:

Release note:

mwieczorek commented 5 years ago

BTW: if you consider this PR and merge it - will it be possible to make a new release?

CecileRobertMichon commented 5 years ago

@mwieczorek can you please close this PR and reopen it in aks-engine? We are in the process of transitioning. There will be no further acs-engine releases, the next on will be in the aks-engine repo. See https://github.com/Azure/aks-engine/blob/master/docs/faq.md for details.

mwieczorek commented 5 years ago

'Moved' to aks-engine