Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

remove resource limit on nginx ingress controller and add topology spread #103

Closed OliverMKing closed 9 months ago

OliverMKing commented 10 months ago

Description

Removes the resource limit on the nginx ingress controller. This allows for app routing to work on clusters with many cpus. NGINX automatically scales worker processes based on node cpus.

We also change the HPA to scale slightly more aggressively. This should lower the amount of CPU used by a single nginx ingress controller replica which means that the actual usage should be more in-line with the Resource Requests (which is good because it's guaranteed).

Pod topology spread ensures nginx ingress controller scheduled on different nodes when possible. Helps avoid single Node failure taking down the Ingress.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Tested on e2e and locally.

Checklist:

coveralls commented 10 months ago

Pull Request Test Coverage Report for Build 6339759755


Totals Coverage Status
Change from base Build 6331531917: 0.07%
Covered Lines: 1980
Relevant Lines: 2230

💛 - Coveralls
OliverMKing commented 10 months ago

/ok-to-test sha=386513c

OliverMKing commented 10 months ago

/ok-to-test sha=386513c

OliverMKing commented 10 months ago

/ok-to-test sha=386513c

OliverMKing commented 10 months ago

/ok-to-test sha=1da477d