Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

managed-by label checks for spc, placeholder pods and ingress backend #111

Closed aamgayle closed 9 months ago

aamgayle commented 9 months ago

Description

Added checks for top-level labels to be sure we're managing a resource before deleting

Fixes # (issue) The Reconcile functions did not check whether or not we owned whatever resource it was currently assessing and could potentially delete secret provider classes and Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

Checklist:

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6645361849


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/keyvault/placeholder_pod.go 10 12 83.33%
<!-- Total: 50 52 96.15% -->
Totals Coverage Status
Change from base Build 6549676137: 0.1%
Covered Lines: 2062
Relevant Lines: 2317

💛 - Coveralls
aamgayle commented 9 months ago

/ok-to-test sha=7331620

aamgayle commented 9 months ago

/ok-to-test sha=c3b2dbf

OliverMKing commented 9 months ago

Pull Request Test Coverage Report for Build 6645361849

  • 50 of 52 (96.15%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.994%

Changes Missing Coverage Covered Lines Changed/Added Lines % pkg/controller/keyvault/placeholder_pod.go 10 12 83.33% Totals Coverage Status Change from base Build 6549676137: 0.1% Covered Lines: 2062 Relevant Lines: 2317

💛 - Coveralls

This all looks good to me. We have a few logic branches not covered for one reconciler that we can add tests for.

aamgayle commented 9 months ago

/ok-to-test sha=1ffab9d

OliverMKing commented 9 months ago

/ok-to-test sha=1ffab9d