Closed davidgamero closed 8 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/controller/keyvault/placeholder_pod.go | 12 | 16 | 75.0% | ||
pkg/manifests/external_dns.go | 33 | 46 | 71.74% | ||
<!-- | Total: | 61 | 78 | 78.21% | --> |
Totals | |
---|---|
Change from base Build 6549676137: | -0.6% |
Covered Lines: | 2050 |
Relevant Lines: | 2322 |
Going to close for now since we've opted not to add sp support. Likely will implement sp support through workload identity in the future
Description
Add the ability to authenticate using service principals instead of MSI
Fixes # (issue) Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
service principal
to the matrix, validating every existing e2e test on the new configurationChecklist: