Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

remove limits and add topology spread #119

Closed OliverMKing closed 9 months ago

OliverMKing commented 9 months ago

Description

Removes the resource limit on the nginx ingress controller. This allows for app routing to work on clusters with many cpus. NGINX automatically scales worker processes based on node cpus.

We also change the HPA to scale slightly more aggressively. This should lower the amount of CPU used by a single nginx ingress controller replica which means that the actual usage should be more in-line with the Resource Requests (which is good because it's guaranteed).

Pod topology spread ensures nginx ingress controller scheduled on different nodes when possible. Helps avoid single Node failure taking down the Ingress.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

e2e and unit

Checklist:

OliverMKing commented 9 months ago

/ok-to-test sha=5adce59

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 6669185625


Totals Coverage Status
Change from base Build 6668986009: 0.03%
Covered Lines: 2068
Relevant Lines: 2323

💛 - Coveralls