OliverMKing commented 8 months ago

Description

Adds a default NginxIngressController reconciler. This makes it so existing App Routing users have a smooth migration to the new CRD-based App Routing.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

E2e, unit, manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 6757420515

81 of 139 (58.27%) changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 77.048%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/nginxingress/nginx_ingress_controller.go	11	24	45.83%
pkg/controller/nginxingress/default.go	65	86	75.58%
pkg/controller/controller.go	0	24	0.0%
<!--	Total:	81	139	58.27%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/controller/controller.go	1	18.46%
<!--	Total:	1		-->

Totals
Change from base Build 6756775295:	-0.5%
Covered Lines:	2699
Relevant Lines:	3503

💛 - Coveralls