Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing

https://learn.microsoft.com/en-us/azure/aks/app-routing

MIT License

29 stars 20 forks source link

switch to use dns hostname as dnsname for cert #133

Closed OliverMKing closed 8 months ago

OliverMKing commented 8 months ago

Description

Switches to use dns hostname as dnsname for cert.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Locally and unit tested

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 6837112192

3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 79.008%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/webhook/cert.go	3	5	60.0%
<!--	Total:	3	5	60.0%	-->

Totals
Change from base Build 6835888941:	0.02%
Covered Lines:	2898
Relevant Lines:	3668

💛 - Coveralls