OliverMKing commented 8 months ago

Description

Triggers a reconcile on nic resources when a managed configmap is updated.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

E2e and unit tested. This is a core feature of how controller runtime works. It doesn't make sense to try to write a unit test for something already tested in the controller runtime package.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 9502123905

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 79.099%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/nginxingress/nginx_ingress_controller.go	0	2	0.0%
<!--	Total:	0	2	0.0%	-->

Totals
Change from base Build 9502119507:	-0.02%
Covered Lines:	3001
Relevant Lines:	3794

💛 - Coveralls

OliverMKing commented 8 months ago

/ok-to-test sha=1799336