Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

move collide function to crd package #140

Closed OliverMKing closed 8 months ago

OliverMKing commented 8 months ago

Description

Moves the collision check to being exported in our crd package. This is needed so we can create custom webhooks outside this repo that use the same logic.

How Has This Been Tested?

e2e and unit tested.

Checklist:

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7008134673


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhook/nginxingress.go 8 10 80.0%
<!-- Total: 40 42 95.24% -->
Files with Coverage Reduction New Missed Lines %
pkg/webhook/nginxingress.go 1 57.38%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 6948852193: 1.4%
Covered Lines: 2951
Relevant Lines: 3680

💛 - Coveralls
OliverMKing commented 8 months ago

/ok-to-test sha=53288d8