Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

set download artifact version to v3 #149

Closed OliverMKing closed 6 months ago

OliverMKing commented 6 months ago

Description

Need to set download artifact version to v3 to match the upload artifact version. Can't use v4 because they switched the scope. https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

It's currently broken because v4 came out.

We should pin to sha anyways. Not sure why this was ever set to main. Security best practice is to use the sha and it's bad to pin to main because it breaks if a breaking change is ever made (like this).

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Workflows

Checklist:

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7399489898


Totals Coverage Status
Change from base Build 7064629368: 0.03%
Covered Lines: 2990
Relevant Lines: 3695

💛 - Coveralls