Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing

https://learn.microsoft.com/en-us/azure/aks/app-routing

MIT License

29 stars 20 forks source link

add yaml-based crd validation + defaults #150

Closed OliverMKing closed 6 months ago

OliverMKing commented 6 months ago

Description

adds yaml-based crd validation to our crd. Reduces the need for webhooks (makes it more acceptable to not use webhooks which add lots of overhead).

Will clean up some old stuff that's not needed anymore in the next PR (and add some stuff to our e2e runner).

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Tested locally and e2e tested.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

OliverMKing commented 6 months ago

Angry unit tests. Will figure out why tomorrow

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7464140143

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 80.915%

Totals
Change from base Build 7413697096:	-0.005%
Covered Lines:	2989
Relevant Lines:	3694

💛 - Coveralls

OliverMKing commented 6 months ago

/ok-to-test sha=7c5e5de