Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
31 stars 23 forks source link

remove webhook logic #151

Closed OliverMKing closed 8 months ago

OliverMKing commented 8 months ago

Description

cleans up webhook related code in favor of crd yaml based validation. Reduces complexity significantly. Need to be testing the non webhook version in e2e which this pr accomplishes.

No need to keep tech debt of webhook code when we aren't planning on using them short term.

Also improves our e2e pass rate significantly with this pr. Improves a few different aspects that have been a bit flaky.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

e2e, unit, and manually

Checklist:

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7492015651


Totals Coverage Status
Change from base Build 7465434181: 1.0%
Covered Lines: 2530
Relevant Lines: 3087

💛 - Coveralls
OliverMKing commented 8 months ago

/ok-to-test sha=d3ab53a

OliverMKing commented 8 months ago

/ok-to-test sha=d3ab53a

OliverMKing commented 8 months ago

/ok-to-test sha=7a1fcc5

OliverMKing commented 8 months ago

/ok-to-test sha=e79ad1c

OliverMKing commented 8 months ago

/ok-to-test sha=7a758be

OliverMKing commented 8 months ago

/ok-to-test sha=b8d80b7