Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

--default-ssl-certificate flag for via CRD #160

Closed aamgayle closed 5 months ago

aamgayle commented 5 months ago

Description

Added functionality to use the --default-ssl-certificate flag via the CRD. The defaultSSLCerfiticate field has a secret field with secretName and secretNamespace properties. From here it enters these in namespace/name format into the --default-ssl-certificate command line command and sets the default ssl certificate for the default HTTPS server

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

Checklist:

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 7758505383


Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1alpha1/zz_generated.deepcopy.go 1 29 3.45%
<!-- Total: 24 52 46.15% -->
Totals Coverage Status
Change from base Build 7747450632: -0.7%
Covered Lines: 2557
Relevant Lines: 3147

💛 - Coveralls
aamgayle commented 5 months ago

/ok-to-test sha=9374b59

aamgayle commented 5 months ago

/ok-to-test sha=7614337

aamgayle commented 5 months ago

/ok-to-test sha=a3b7596

OliverMKing commented 5 months ago

/ok-to-test sha=a3b7596

aamgayle commented 5 months ago

/ok-to-test sha=7eff4ed

OliverMKing commented 5 months ago

/ok-to-test sha=7eff4ed

OliverMKing commented 5 months ago

/ok-to-test sha=7eff4ed

MXClyde commented 3 months ago

@OliverMKing Is there a way to trigger receiving this enhancement in an active AKS cluster? It seems like it isn't live yet (at least in West Europe region), as i'm getting an unknown field error when trying to apply the setting...

OliverMKing commented 3 months ago

@OliverMKing Is there a way to trigger receiving this enhancement in an active AKS cluster? It seems like it isn't live yet (at least in West Europe region), as i'm getting an unknown field error when trying to apply the setting...

This will be released shortly. It's not released yet but I'll let you know when it is.

It will be part of the AKS release notes when it is

MXClyde commented 1 month ago

@OliverMKing I see the new version appeared on the AKS release notes but I cannot get it working on a newly deployed cluster (in a region that has the new version according to the release tracker). Is below syntax correct?

apiVersion: approuting.kubernetes.azure.com/v1alpha1
kind: NginxIngressController
metadata:
  name: default
  namespace: app-routing-namespace
spec:
  ingressClassName: webapprouting.kubernetes.azure.com
  controllerNamePrefix: nginx
  defaultSSLCertificate: "mendix/wildcard-tls-cert"
OliverMKing commented 1 month ago

@OliverMKing I see the new version appeared on the AKS release notes but I cannot get it working on a newly deployed cluster (in a region that has the new version according to the release tracker). Is below syntax correct?

This should be documented in release notes, but it will only be available on clusters with k8s versions 1.30 and up. This is due to AKS addon breaking change policies.

@sabbour for visibility.