search

Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

Enable SSL Passthrough #165

Open EdSalzedo opened 5 months ago

EdSalzedo commented 5 months ago

Hi,

I'd like to be able to add --enable-ssl-passthrough as an argument for starting up NGINX. I currently can't find a way of doing it while using the app-routing plugin, would this be possible?

Thanks,

Ed

OliverMKing commented 5 months ago

Hi @EdSalzedo! Thanks for reaching out.

It's not possible to enable ssl-passthrough globally today but you can enable it through Ingress annotations on individual Ingresses. This is documented here.

We can look into adding a way of configuring this globally to App Routing. Tagging @sabbour so we can add it to the backlog.

Thanks!

EdSalzedo commented 4 months ago

Hi, thanks for responding @OliverMKing!

I think without -enable-ssl-passthrough flag set on startup, the nginx.ingress.kubernetes.io/ssl-passthrough annotation has no effect based on the testing I've done, although I could have got that wrong.

It'd be useful to be able to configure it at some point so thank you!

OliverMKing commented 4 months ago

Hi, thanks for responding @OliverMKing!

I think without -enable-ssl-passthrough flag set on startup, the nginx.ingress.kubernetes.io/ssl-passthrough annotation has no effect based on the testing I've done, although I could have got that wrong.

It'd be useful to be able to configure it at some point so thank you!

You are correct! The documentation even says it, which I missed. We will look into this.

MXClyde commented 1 month ago

I also have a use-case that needs this feature so forgive me a +1

zjylo commented 1 week ago

Another similar use case is enabling -use-forwarded-headers , we're using Azure Front Door which is setting these values and then getting overwritten by Nginx.

Have to deploy manually for now till this is enabled.