Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
29 stars 20 forks source link

defaultSSLCertificate via key vault URI #166

Closed aamgayle closed 3 months ago

aamgayle commented 4 months ago

Description

This will allow users to set a default SSL Certificate via keyvault URI. It uses a new reconciler that watches the CRD for the addition of a keyvault URI under defaultSSLCertificate and creates and points the nginx manifest to an associated SPC afterward.

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

Checklist:

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8458009406

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/controller.go 0 4 0.0%
pkg/controller/keyvault/kv_util.go 93 97 95.88%
api/v1alpha1/zz_generated.deepcopy.go 0 5 0.0%
pkg/controller/keyvault/ingress_secret_provider_class.go 21 26 80.77%
pkg/controller/keyvault/placeholder_pod.go 49 56 87.5%
pkg/controller/keyvault/nginx_secret_provider_class.go 76 99 76.77%
<!-- Total: 246 294 83.67% -->
Totals Coverage Status
Change from base Build 8436857218: -0.06%
Covered Lines: 2823
Relevant Lines: 3527

💛 - Coveralls
OliverMKing commented 3 months ago

/ok-to-test sha=cda8f47

OliverMKing commented 3 months ago

Looking good! Just a few small nits

OliverMKing commented 3 months ago

/ok-to-test sha=3e66697