OliverMKing commented 6 months ago

Description

lets users configure min and max replicas through crd

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Unit, e2e, and manually tested.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8300795484

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

20 of 43 (46.51%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 80.778%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/v1alpha1/zz_generated.deepcopy.go	1	24	4.17%
<!--	Total:	20	43	46.51%	-->

Totals
Change from base Build 8299995013:	-0.5%
Covered Lines:	2576
Relevant Lines:	3189

💛 - Coveralls