Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing

https://learn.microsoft.com/en-us/azure/aks/app-routing

MIT License

29 stars 20 forks source link

deduplicate dns zones passed to operator #182

Closed OliverMKing closed 3 months ago

OliverMKing commented 3 months ago

Description

Deduplicates any dns zones passed to the operator. Will need similar logic of some form in RP too.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Locally, e2e, unit

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

OliverMKing commented 3 months ago

/ok-to-test sha=f7aa9a3

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 8365822860

Details

19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.9%) to 79.859%

Totals
Change from base Build 8363627571:	-0.9%
Covered Lines:	2609
Relevant Lines:	3267

💛 - Coveralls

OliverMKing commented 3 months ago

/ok-to-test sha=f7aa9a3

OliverMKing commented 3 months ago

failing test coverage check because I added a unit test to utils which had no coverage before. should add more unit tests to utils later