Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing

https://learn.microsoft.com/en-us/azure/aks/app-routing

MIT License

31 stars 23 forks source link

swap to default http/s ports for Nginx #202

Closed OliverMKing closed 5 months ago

OliverMKing commented 5 months ago

Description

swaps us to the default http/s ports for the Nginx deployment. Without this, some redirection annotations behave unexpectedly.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

manual, e2e, unit

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8833813938

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 80.476%

Files with Coverage Reduction	New Missed Lines	%
pkg/controller/ingress/concurrency_watchdog.go	1	86.41%
<!--	Total:	1		-->

Totals
Change from base Build 8821796218:	-0.04%
Covered Lines:	2910
Relevant Lines:	3616

💛 - Coveralls

OliverMKing commented 5 months ago

/ok-to-test sha=acea5c8