Closed NickKeller closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/controller/ingress/concurrency_watchdog.go | 7 | 8 | 87.5% | ||
pkg/controller/common/resource_reconciler.go | 4 | 6 | 66.67% | ||
pkg/controller/keyvault/ingress_secret_provider_class.go | 17 | 20 | 85.0% | ||
pkg/controller/osm/ingress_backend_reconciler.go | 16 | 19 | 84.21% | ||
pkg/controller/osm/ingress_cert_config_reconciler.go | 14 | 18 | 77.78% | ||
pkg/controller/service/ingress_reconciler.go | 14 | 19 | 73.68% | ||
pkg/controller/keyvault/placeholder_pod.go | 16 | 22 | 72.73% | ||
pkg/controller/keyvault/event_mirror.go | 12 | 20 | 60.0% | ||
pkg/controller/common/cleaner.go | 0 | 21 | 0.0% | ||
<!-- | Total: | 100 | 153 | 65.36% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/controller/keyvault/placeholder_pod.go | 2 | 84.3% | ||
pkg/controller/common/cleaner.go | 4 | 34.35% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 5731338555: | 0.6% |
Covered Lines: | 1590 |
Relevant Lines: | 2036 |
/ok-to-test sha=4af5d63
/ok-to-test sha=b2a8d1c
Discussed nits with Jaiveer. We decided they aren't blocking so merged this in.
Description
Adds metric reporting to the controller runs
Fixes # (issue) Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: