Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing

https://learn.microsoft.com/en-us/azure/aks/app-routing

MIT License

30 stars 20 forks source link

disable cleaner #78

Closed OliverMKing closed 1 year ago

OliverMKing commented 1 year ago

Description

Disables the cleaner temporarily while we improve testing. Also makes protects manifest generation from race conditions.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Unit and e2e tested

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

OliverMKing commented 1 year ago

/ok-to-test sha=d1a8825

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5789691433

26 of 29 (89.66%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 78.114%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller/dns/external_dns.go	1	4	25.0%
<!--	Total:	26	29	89.66%	-->

Totals
Change from base Build 5788359255:	0.02%
Covered Lines:	1599
Relevant Lines:	2047

💛 - Coveralls

OliverMKing commented 1 year ago

/ok-to-test sha=ef650c4