Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
30 stars 20 forks source link

Adding ControllerName struct, and test cases #84

Closed Marcus-Hines closed 1 year ago

Marcus-Hines commented 1 year ago

Description

Continuing to enforce Prometheus best practices for metics. Adding a struct that ensures naming conventions are upheld, and uniformity exists between metric naming and logger

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

Checklist:

OliverMKing commented 1 year ago

unit tests are failing right now

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5956001568


Totals Coverage Status
Change from base Build 5929363980: 3.8%
Covered Lines: 1857
Relevant Lines: 2068

💛 - Coveralls
OliverMKing commented 1 year ago

/ok-to-test sha=83bd476

OliverMKing commented 1 year ago

/ok-to-test sha=0e5659b