Closed OliverMKing closed 1 year ago
/ok-to-test sha=dc2e802
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/controller/dns/external_dns.go | 1 | 2 | 50.0% | ||
pkg/controller/controllername/controllername.go | 12 | 18 | 66.67% | ||
<!-- | Total: | 28 | 35 | 80.0% | --> |
Totals | |
---|---|
Change from base Build 5963965196: | -0.2% |
Covered Lines: | 1857 |
Relevant Lines: | 2074 |
/ok-to-test sha=d397a9a
/ok-to-test sha=d9ef721
Description
Adds controller name interface to all controllers. Allows for us to enforce consistent logging and metric naming for all controllers. Will be useful for alerting based on prometheus especially. If an alert fires we can attach an automatically generated query that can search relevant controller logs for that alert.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit and e2e tested
Checklist: