Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
30 stars 20 forks source link

add controller name interface to all controllers #85

Closed OliverMKing closed 1 year ago

OliverMKing commented 1 year ago

Description

Adds controller name interface to all controllers. Allows for us to enforce consistent logging and metric naming for all controllers. Will be useful for alerting based on prometheus especially. If an alert fires we can attach an automatically generated query that can search relevant controller logs for that alert.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Unit and e2e tested

Checklist:

OliverMKing commented 1 year ago

/ok-to-test sha=dc2e802

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5966036453


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/dns/external_dns.go 1 2 50.0%
pkg/controller/controllername/controllername.go 12 18 66.67%
<!-- Total: 28 35 80.0% -->
Totals Coverage Status
Change from base Build 5963965196: -0.2%
Covered Lines: 1857
Relevant Lines: 2074

💛 - Coveralls
OliverMKing commented 1 year ago

/ok-to-test sha=d397a9a

OliverMKing commented 1 year ago

/ok-to-test sha=d9ef721