Azure / aks-app-routing-operator

Kubernetes operator that implements AKS Application Routing
https://learn.microsoft.com/en-us/azure/aks/app-routing
MIT License
30 stars 20 forks source link

add controller logging format to managed controllers #86

Closed OliverMKing closed 1 year ago

OliverMKing commented 1 year ago

Description

We have two kinds of controllers in app routing. For controllers that are created completely through controller manager they have an internal logging format where they add a few additional fields. We need to add our controller fields to this logger when creating these controllers or else they will be missing fields we want on all controller logs.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Tested manually and with e2e and unit

Checklist:

OliverMKing commented 1 year ago

/ok-to-test sha=7a0d75

OliverMKing commented 1 year ago

/ok-to-test sha=7a07d75

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5968756965


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/service/ingress_reconciler.go 0 6 0.0%
pkg/controller/keyvault/ingress_secret_provider_class.go 0 10 0.0%
pkg/controller/controllername/controllername.go 0 12 0.0%
<!-- Total: 22 50 44.0% -->
Files with Coverage Reduction New Missed Lines %
pkg/controller/service/ingress_reconciler.go 1 84.31%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 5968033748: -0.6%
Covered Lines: 1862
Relevant Lines: 2094

💛 - Coveralls