Azure / aks-devx-tools

Create deployment files and configure GitHub Actions workflows to deploy applications to Azure Kubernetes Service (AKS).
MIT License
17 stars 17 forks source link

add web app routing experience #74

Closed OliverMKing closed 1 year ago

OliverMKing commented 1 year ago

Description

Type of change

How Has This Been Tested?

Unit tested where possible. Tested locally for everything else. Will get pms to fully test before releasing but this is already such a huge update it makes sense to get it merged in than make incremental improvements.

I do want to improve the deploy experience to link to the generated ingress address but this pr is already huge.

Checklist:

OliverMKing commented 1 year ago

Will squash merge this whenever it's merged in haha

OliverMKing commented 1 year ago

looks good to me apart from minor typo but do we have a plan for the future to replace manual/local testing?

There's ways to fully e2e test extensions like https://github.com/redhat-developer/vscode-extension-tester plus something similar to what you did in K8s-deploy. When we add it will just depend on our priorities.