Azure / aml-workspace

GitHub Action that allows you to create or connect to your Azure Machine Learning Workspace.
MIT License
22 stars 15 forks source link

Running action now fails #11

Closed totosan closed 4 years ago

totosan commented 4 years ago

When running action, it fails since 15th of may. Container builds in workflow, but according action does fail with the message "ls: cannot access 'code': No such file or directory"

image

From what I can see, is that the command ls in entrypoint.sh is in general correct. Removing ls from local build makes this working as expected. (Using nektos/act for local tests.)

This is the error message: image

marvinbuss commented 4 years ago

@totosan Thanks for submitting this. We will fix this today or tomorrow.

totosan commented 4 years ago

I already made one with this PR #12 Also please check following repos (will not spam issue lists :-) ):

marvinbuss commented 4 years ago

@totosan Sorry for the late reply. Are you running a special setup? Are you running self-hosted runners, etc.? We ran a couple of tests (unit + integration) and could not reproduce the issue. I would like to include your setup as a test case.

totosan commented 4 years ago

No, no self-hosted. Nothing special. I was using suggested yml from Azure Machine Learning example Repo.

totosan commented 4 years ago

Maybe a silly question, but how can the secret be set in the PR - Integration test of your repo. My Pr fails, because secret is not set. btw. I am using a private repo with ubuntu:latest as image.

aronchick commented 4 years ago

You have to set a secret in your repo - here's instructions https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

totosan commented 4 years ago

Hi @aronchick, thx, the PR from my forked repo is running against this repo here. I set the secret at my repo, already. Maybe, I misunderstood something.

marvinbuss commented 4 years ago

Maybe a silly question, but how can the secret be set in the PR - Integration test of your repo. My Pr fails, because secret is not set. btw. I am using a private repo with ubuntu:latest as image.

@totosan You have to add the secrets to this repo: https://github.com/totosan/aml-workspace

Can you please check the referenced branch and check whether it works as expected for you? We will merge this soon. The same changes will be made to the other repos.

totosan commented 4 years ago

GitHub has currently some issues, preventing me from testing. Going to test tomorrow then. Incident

marvinbuss commented 4 years ago

@totosan Can you please confirm whether the bugs are fixed in all master branches (aml-workspace, aml-compute, ...) ? It is shown here how you can test the master branch of the AML Actions: https://github.com/marvinbuss/mlops/blob/be7a6470d76eb784c40d2bce46178d2d6cadbdd7/.github/workflows/train_deploy.yml#L16

I could not reproduce the error in my repo, but it would be great if you could provide some feedback. Draft releases have already been created and will be made public once you confirm.

marvinbuss commented 4 years ago

@totosan did you have a chance to test the changes in master of aml-workspace?

totosan commented 4 years ago

Yeah, it's working like a charm. From my perspective, the bug is resolved. Thx a lot.

marvinbuss commented 4 years ago

Great. I will release a new version tonight. You can switch back to v1 tomorrow. Thanks for submitting the bug.

Feel free to submit additional feature requests and bugs in the future.

marvinbuss commented 4 years ago

I released an update to all AML Actions, which should fix the bug. Please reopen the issue, if it persists. You can now use the v1 tag (aml-workspace@v1) again in your yaml workflows.