search

Azure / aml-workspace

GitHub Action that allows you to create or connect to your Azure Machine Learning Workspace.
MIT License
22 stars 16 forks source link

Fixed line ending in aml-workspace - fixes #11 #12

Closed totosan closed 4 years ago

totosan commented 4 years ago

Wrong line ending stops container from running

Fix for issue #11

Purpose of this PR is

to prevent container for stopping when running entrypoint shell 'entrypoint.sh'

Error description

running the container leads to stop with error stating "ls: no such file or directory"

Cause

files in repository are checked in with CRLF line ending (\r\n) which is not supported in Linux OS. The Docker container, that is build is based on Ubuntu Linux.

Solution

handling file line endings (CR/LF) by adding a .gitattributes file, with rules regarding line endings for different file types

totosan commented 4 years ago

fixes issue #11

awmatheson commented 4 years ago

@totosan are you using the default actions runner or a different one (self-hosted, macOS, etc.)

totosan commented 4 years ago

I am using the defaults.

awmatheson commented 4 years ago

This is a good point that we don't actually need the ls in the entrypoint. I will open a PR to remove it.

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.