Added input validation & unit tests

Azure / aml-workspace

GitHub Action that allows you to create or connect to your Azure Machine Learning Workspace.

MIT License

22 stars 16 forks source link

Added input validation & unit tests #5

Closed marvinbuss closed 4 years ago

marvinbuss commented 4 years ago

[x] Added first unit tests
[x] Added validation test

marvinbuss commented 4 years ago

@awmatheson

[x] fix input validation bug
[x] add additional tests

marvinbuss commented 4 years ago

@awmatheson Please review and test with different inputs. Feel free to add additional unit tests. I will also test tomorrow.

awmatheson commented 4 years ago

I had split the test and lint because I thought it might be clearer on the checks, but also fine to leave it as one.

awmatheson commented 4 years ago

@marvinbuss I noticed that the validation will not raise any error with missing or misspelled required field for the workspace.json. I added the required fields so that they matched the Readme.md and added a test to check for this.

marvinbuss commented 4 years ago

[x] Switch to SDK 1.4.0

marvinbuss commented 4 years ago

@awmatheson The parameters are not actually required, if the user sets things up correctly. The documentation is not correct. Should we change the JSON or the documentation?