search

Azure / amqpnetlite

AMQP 1.0 .NET Library
Apache License 2.0
402 stars 145 forks source link

AmqpSettings.IdleTimeout int to uint #577

Closed optimuserik closed 10 months ago

optimuserik commented 11 months ago

Change the default AmqpSettings.IdleTimeout from int to uint. Chenge the initialization from int.MaxValue to uint.MaxValue

optimuserik commented 11 months ago

@microsoft-github-policy-service agree

optimuserik commented 11 months ago

@microsoft-github-policy-service agree

optimuserik commented 11 months ago

@microsoft-github-policy-service rerun

xinchen10 commented 10 months ago

Unfortunately this is a breaking change which we are trying to avoid as much as possible.

Let me check the feasibility of still using an int type but allowing negative values, with "-1" being the special case for infinite (no timeout).

xinchen10 commented 10 months ago

@optimuserik I made a change to allow using -1 for infinite idle timeout. Can you verify if that resolves the issue you observed?

optimuserik commented 10 months ago

@xinchen10 It does solve the issue. Thank you :) . I will abandon this PR and mark the problem solved with your commit. Awaiting the release.