Fixed: API not loaded the first time

Azure / api-management-developer-portal

Developer portal provided by the Azure API Management service.

MIT License

486 stars 313 forks source link

Fixed: API not loaded the first time #2424

Closed malincrist closed 7 months ago

malincrist commented 7 months ago

Problem

When navigating on a page that has API: Details widget, the first time the user selects an API (from the widget API: list for example), it is not loaded. This is happening due to the order of the operations in the initialization flow: if there is no API in the URL initially we return without subscribing to onRouteChange(). Hence, even if the route changes, the API: Details widget doesn't react.

Solution

Subscribe to onRouteChange() even if there is no API in the URL.

Closes #2421

github-actions[bot] commented 7 months ago

Accessibility Insights Action: All applicable checks passed

URLs: 13 URL(s) passed, and 0 were not scannable
Rules: 29 check(s) passed, and 23 were not applicable
Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

MarvinVaillant commented 7 months ago

Thanks a lot for the fix :)