Azure / api-management-self-hosted-gateway

Home of Azure API Management's Self-Hosted Gateway
https://docs.microsoft.com/en-gb/azure/api-management/self-hosted-gateway-overview
Other
65 stars 26 forks source link

Helm charts not respecting namespace when (helm template --namespace) is used to generate the manifests #295

Closed midhun-mohan closed 1 month ago

midhun-mohan commented 1 month ago

Report

The current helm charts for apim self hosted gateway doesn't respect using the --namespace flag when using the helm template command. Ideally, this should be respected.

Expected Behavior

Helm template with --namespace flags generate resources with .metadata.namespace set

Actual Behavior

The manifests are being generated without .metadata.namespace set when --namespace= is being used.

Steps to Reproduce the Problem

  1. Run helm repo add azure-apim-gateway https://azure.github.io/api-management-self-hosted-gateway/helm-charts/
~  helm repo list | grep gateway
azure-apim-gateway  https://azure.github.io/api-management-self-hosted-gateway/helm-charts/
  1. Run helm template --namespace=apim-gateway apim azure-apim-gateway/azure-api-management-gateway --set=gateway.auth.key=<gatewayAuthKey>--set gateway.configuration.uri=<gatewayConfigurationUri> This generates manifests without .metadata.namespace being set.
helm template --namespace=apim-gateway apim azure-apim-gateway/azure-api-management-gateway --set=gateway.auth.key=dddddd --set gateway.configuration.uri=wwwwwww | grep metadata -A 3
metadata:
  name: apim-azure-api-management-gateway
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
metadata:
  name: apim-azure-api-management-gateway
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
metadata:
  name: apim-azure-api-management-gateway
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
metadata:
  name: apim-azure-api-management-gateway-instance-discovery
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
metadata:
  name: apim-azure-api-management-gateway
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
metadata:
  name: apim-azure-api-management-gateway
  labels:
    helm.sh/chart: azure-api-management-gateway-1.10.0
--
    metadata:
      labels:
        app.kubernetes.io/name: apim-azure-api-management-gateway
        app.kubernetes.io/component: self-hosted-gateway
--
metadata:
  name: "apim-azure-api-management-gateway-test-connection"
  labels:
    app.kubernetes.io/name: azure-api-management-gateway

Logs from self-hosted gateway

NA

Self-hosted Gateway Version

v1.10.0

Deployment

Self-Managed (YAML/Helm)

Platform

None

Kubernetes Version

None

Anything else?

I can contribute with a PR if needed :

midhun-mohan commented 1 month ago

https://github.com/Azure/api-management-self-hosted-gateway/pull/296