Added changes to reflect the new color api and website urls.

Azure / apim-lab

API Management - Hands-on Lab Workshop

https://azure.github.io/apim-lab/

MIT License

74 stars 81 forks source link

Added changes to reflect the new color api and website urls. #105

Closed pkal42 closed 1 year ago

pkal42 commented 1 year ago

Please review and let me know if you've any updates/feedback.

pkal42 commented 1 year ago

@microsoft-github-policy-service agree [company="{Microsoft}"]

pkal42 commented 1 year ago

@pkal42 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree

simonkurtz-MSFT commented 1 year ago

@pkal42, please don't use a dark mode or incognito window for the screenshot for these assets. All screenshots should be on light theme to be consistent.

assets/images/apim-color-api-url-in-browser-starter-product-429.png
assets/images/notepad-color-api-subscription-keys.png

simonkurtz-MSFT commented 1 year ago

@pkal42, some of the screenshots are very wide. How do they look when viewed in the labs? Please ensure they don't appear small and hard to read.

pkal42 commented 1 year ago

Thank you @simonkurtz-MSFT for the feedback and discussion. Just wanted to summarize our discussion for other reviewers:

Though we have referenced this as Color API/Website, we will reference going forward as Colors API/Website as that's how it shows up in routing.
Since the new Colors API has routing /colors/random, for the sake of simplicity, we will not provide api url suffix, and add a note that this might introduce and conflict, and you can leverage rewrite-uri policy.
Work on reducing image sizes and using light backgrounds for two images. @ferantoMSFT, @Chad-Dumas-MSFT, if you've any other feedback, please share by Jan 5th, so that we can make all the changes together. Really appreciate your feedback. Thank you!

pkal42 commented 1 year ago

@simonkurtz-MSFT, thank you so much again for your feedback. Please take a look at the latest updates. Thank you!