build/fixing-container-and-dependancies

Azure / apim-lab

API Management - Hands-on Lab Workshop

https://azure.github.io/apim-lab/

MIT License

74 stars 81 forks source link

Closed reidav closed 1 year ago

reidav commented 1 year ago

Suggesting several fixes / upgrades :

devcontainer is now working also reusing official devcontainer ruby template
upgrading dependancies, aligning it with github pages official recommendation for jekyll : https://pages.github.com/versions/

simonkurtz-MSFT commented 1 year ago

LGTM. @ferantoMSFT and @Chad-Dumas-MSFT, would be great to get another set of eyes on this PR, please.

reidav commented 1 year ago

Many thanks @simonkurtz-MSFT for your feedback ! Any update / review please @ferantoMSFT or @Chad-Dumas-MSFT ? Thx