search

Azure / apiops

APIOps applies the concepts of GitOps and DevOps to API deployment. By using practices from these two methodologies, APIOps can enable everyone involved in the lifecycle of API design, development, and deployment with self-service and automated tools to ensure the quality of the specifications and APIs that they’re building.
https://azure.github.io/apiops
MIT License
329 stars 193 forks source link

Add missing override for ApiDiagnostics in Publisher #653

Closed jeroenmaes closed 2 months ago

jeroenmaes commented 2 months ago

In V6.0.1.1 the override logic for ApiDiagnostics is missing in the Publisher.

jeroenmaes commented 2 months ago

Issue was mentioned in https://github.com/Azure/apiops/issues/627

guythetechie commented 2 months ago

Appreciate the PR, but our configuration system currently only supports top-level resources. If an override is specified in configuration, we assume it's for the service-level resource; not for nested resources. We can't assume that a nested resource is the same as a top-level resource simply because they have the same name.

We will work on a more robust implementation to support something like this:

diagnostics:
  diagnosticA:
    properties:
      loggerId: abc
apis:
  apiA:
    diagnostics:
      diagnosticA:
        properties:
          loggerId: efg