search

Azure / apiops

APIOps applies the concepts of GitOps and DevOps to API deployment. By using practices from these two methodologies, APIOps can enable everyone involved in the lifecycle of API design, development, and deployment with self-service and automated tools to ensure the quality of the specifications and APIs that they’re building.
https://azure.github.io/apiops
MIT License
324 stars 191 forks source link

define AZURE_CLIENT_ID, AZURE_RESOURCE_GROUP_NAME,API_MANAGEMENT_SERVICE_NAME as variables instead of secrets #654

Closed gadamsettie2 closed 3 weeks ago

gadamsettie2 commented 2 months ago

Release version

v6.0.1.1

Question Details

Having defined the mentioned values as variables makes the debugging process to difficult to understand which value is being used.

I would recommend the following values as variables instead of secrets. AZURE_CLIENT_ID AZURE_RESOURCE_GROUP_NAME API_MANAGEMENT_SERVICE_NAME

Thanks, Sagar

Expected behavior

Defining them as variables would be ideal.

Actual behavior

Defined as secrets.

Reproduction Steps

execute as is.

github-actions[bot] commented 2 months ago 
  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.
guythetechie commented 3 weeks ago

@gadamsettie2 - our ADO/GitHub pipelines are only meant to provide a working starting point. You should customize them to fit your needs. If you prefer variables over secrets, please feel free to change them in your environment.