Azure / apiops

APIOps applies the concepts of GitOps and DevOps to API deployment. By using practices from these two methodologies, APIOps can enable everyone involved in the lifecycle of API design, development, and deployment with self-service and automated tools to ensure the quality of the specifications and APIs that they’re building.
https://azure.github.io/apiops
MIT License
328 stars 193 forks source link

feat: uncommenting item that reflects on the document links problem #658

Open felipementel opened 2 months ago

felipementel commented 2 months ago

I believe the issue in item #607 will be resolved with this commit.

felipementel commented 2 months ago

Hi @waelkdouh, how are you?

Just like in my first comment on this pull request, I believe I have found the problem that is breaking the documentation links, and for that I originally created this pull request.

Today I updated the packages that need updating, and I have combined them in this same pull request.

If I think this could negatively affect the repository, I can cancel this request and create two separate ones.

I await your contact, thank you

waelkdouh commented 2 months ago

Hi @felipementel could you elaborate a bit more on what you mean by it could pretend it could negatively affect this repository? I'm just trying to understand why you are suggesting creating two separate requests.

felipementel commented 2 months ago

@waelkdouh The reason would be the scope of the update.

There is a request for a documentation update, which refers to the problem and another scope, which is the update of the nuget packages.

unfortunately, due to a "mistake" of mine, I combined everything in the same PR

waelkdouh commented 2 months ago

Gotcha. No worries I will review and report back here accordingly. Thanks again for your contributions.