Azure / apiops

APIOps applies the concepts of GitOps and DevOps to API deployment. By using practices from these two methodologies, APIOps can enable everyone involved in the lifecycle of API design, development, and deployment with self-service and automated tools to ensure the quality of the specifications and APIs that they’re building.
https://azure.github.io/apiops
MIT License
328 stars 193 forks source link

[BUG] API diagnostics are not being updated on deployment #703

Open tomsauret21 opened 1 week ago

tomsauret21 commented 1 week ago

Release version

V6.0.1.3

Describe the bug

When deploying an API, the value from the JSON file is being used and the value from the configuration file is being ignored. This is causing deployments to fail if the API has the diagnostic settings enabled. This is the same issue that was reported in #672

Expected behavior

Be able to deploy APIs with diagnostic settings into other environments

Actual behavior

The deployment fails out with error it cannot find the logger ID in that environment

Reproduction Steps

Check the box in the settings of the API to enable diagnostics on the API Extract the API and ensure it has a diagnostics folder with it Update the config file to have the diagnostics setting for the environment you are deploying to Run the publisher and wait for the error

github-actions[bot] commented 1 week ago
  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.
LukaszHryniewiecki commented 3 days ago

I can confirm it seems that issue still exists in newest release