Azure / apiops

APIOps applies the concepts of GitOps and DevOps to API deployment. By using practices from these two methodologies, APIOps can enable everyone involved in the lifecycle of API design, development, and deployment with self-service and automated tools to ensure the quality of the specifications and APIs that they’re building.
https://azure.github.io/apiops
MIT License
328 stars 193 forks source link

[BUG] extractor exctracts all Versions sets even when excluded #705

Closed martin2176 closed 6 days ago

martin2176 commented 1 week ago

Release version

v6.0.1.3

Describe the bug

I am using versionSetNames: [none] in configuration.extractor.yaml However extractor still extracts all the version sets regardless.

Image

Expected behavior

Extractor should skip extracting version sets if none is specified or only extract specific version sets .

Actual behavior

extractor extracts all the version sets regardless of what is specified in configuration.extractor.yaml Image

Reproduction Steps

add to configuration.extractor.yaml versionSetNames:

Run extractor workflow. Once the artifacts are uploaded, check the artifacts. You will find all the versionsets included in the artifact

github-actions[bot] commented 1 week ago
  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.
martin2176 commented 6 days ago

Closing this issue. I was infact not looking at what was added in the commit instead I was looking at all the files upto and including the commit. Extractor for versionset seems to be working fine