search

Azure / app-service-announcements-discussions

Discussions for announcements from https://github.com/Azure/app-service-announcements/
MIT License
44 stars 5 forks source link

[Discussion] Removal of Azure Functions version 4.23.0 #338

Open VpOfEngineering opened 1 year ago

VpOfEngineering commented 1 year ago

Discussion issue for removal of Azure Functions version 4.23.0

ShirAvneri commented 1 year ago

Since newer runtimes include a breaking change, the late notification is very disappointing, as our production environment is majorly affected.

brettsam commented 12 months ago

@ShirAvneri (and others) -- what breaking change are you speaking of, directly? We never intend to introduce breaks -- but we want to make sure we're tracking any that are found.

We know the IdentityModel package introduced a change that hit at least one customer.

ShirAvneri commented 12 months ago

@ShirAvneri (and others) -- what breaking change are you speaking of, directly? We never intend to introduce breaks -- but we want to make sure we're tracking any that are found.

We know the IdentityModel package introduced a change that hit at least one customer.

I am referring to the Identity dependencies, which were upgraded to 6.31.0 in the next version, introducing a breaking change.

brettsam commented 12 months ago

Because of this (unexpected) breaking change in those minor-versioned packages, we've decided to not remove 4.23.0 until we have a resolution. Having more details from folks as to why they pinned to 4.23.0 would be very helpful. We know of two issues:

  1. Various Method not found runtime errors due to minor version mismatches and usage of InternalsVisibleTo in IdentityModel packages
  2. Key size enforcement (https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2072)

We're working with the IdentityModel team on this.

ShirAvneri commented 12 months ago

Because of this (unexpected) breaking change in those minor-versioned packages, we've decided to not remove 4.23.0 until we have a resolution. Having more details from folks as to why they pinned to 4.23.0 would be very helpful. We know of two issues:

  1. Various Method not found runtime errors due to minor version mismatches and usage of InternalsVisibleTo in IdentityModel packages
  2. Key size enforcement (https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2072)

We're working with the IdentityModel team on this.

We pinned to 4.23.0 due to the key size enforcement, a resolution suggested by Microsoft support... The first time it hit us was a month ago.