search

Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 10 forks source link

Kafka rule should have been triggered #120

Open agoncal opened 1 year ago

agoncal commented 1 year ago

We have one case where the application has a Kafka Client library (WEB-INF/lib/kafka-clients-3.4.0.jar). AppCAT reported it in the discovery target Embedded library - Kafka Client.

We have created a rule for Kafka, so it should have appeared on the AppService target, not discovery

https://github.com/Azure/appcat-rulesets/pull/114/files

brunoborges commented 2 months ago

@agoncal can you test this again please?

@kthatipally FYI if you can.

kthatipally commented 2 months ago

@agoncal , The PR mentioned in the issue looks like it was never merged in. The only existing rule for kafka is in the connect.windup.groovy in technology-usage (discovery target): https://github.com/Azure/appcat-rulesets/blob/2267f1ff5466c940e05a30b3222a3026e30c00ca/rules/rules-reviewed/technology-usage/connect.windup.groovy#L175

brunoborges commented 2 months ago

We reopened #114 to see if the tests pass. Let's review once again.