search

Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 10 forks source link

config server usage should be reported on for spring boot apps #125

Closed vermegi closed 1 year ago

vermegi commented 1 year ago

Similar to the reporting of eureka usage (https://github.com/Azure/appcat-rulesets/blob/main/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-eureka.windup.xml) appcat should also report on config-server usage. This is also functionality provided OOB by spring apps, so would be nice to see it in the report.

agoncal commented 1 year ago

We already have a rule that looks for Spring Config imports.

We should enrich this rule so it can detect the spring-cloud-config-server dependency:

<dependency>
    <groupId>org.springframework.cloud</groupId>
    <artifactId>spring-cloud-config-server</artifactId>
</dependency>

As well as checking for the org.springframework.cloud.config.server.EnableConfigServer.EnableConfigServer annotation

vermegi commented 1 year ago

Btw, for spring petclinic the config server dependency did not get picked up, because of issue #124 where in the config files it has newlines. So for the existing rule you mention, that one should also take newlines into account.