Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 10 forks source link

Double check ruleset with spring cloud migration docs #127

Closed vermegi closed 1 year ago

vermegi commented 1 year ago

There are migration docs at https://learn.microsoft.com/en-us/azure/developer/java/migration/migrate-spring-cloud-to-azure-spring-apps?toc=%2Fazure%2Fspring-apps%2Ftoc.json&bc=%2Fazure%2Fspring-apps%2Fbreadcrumb%2Ftoc.json&pivots=sc-standard-tier and https://learn.microsoft.com/en-us/azure/spring-apps/how-to-prepare-app-deployment?tabs=enterprise-plan&pivots=programming-language-java

The current ruleset should be cross checked with the guidance in these docs so all rules are there.

For instance I didn't find a rule for "spring.cloud.config.tls.keystore"

This issue should probably be split out after the cross check to see what rules are missing.

### Tasks
- [ ] https://github.com/Azure/appcat-rulesets/issues/136
- [ ] https://github.com/Azure/appcat-rulesets/issues/135
- [ ] https://github.com/Azure/appcat-rulesets/issues/134
- [ ] https://github.com/Azure/appcat-rulesets/issues/137
- [ ] https://github.com/Azure/appcat-rulesets/issues/138
- [ ] https://github.com/Azure/appcat-rulesets/issues/139
- [ ] https://github.com/Azure/appcat-rulesets/issues/140
- [ ] https://github.com/Azure/appcat-rulesets/issues/141
KaiqianYang commented 1 year ago

@vermegi Yes, currently points in migration docs are not fully implemented in AppCat. We will plan these tasks in this stage or next stage. Thank you for reporting.